Skip to content

[Microsoft SQL Server] metrics for Always On Availability Groups #16759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jakubgalecki0 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Microsoft SQL Server] metrics for Always On Availability Groups #16759

jakubgalecki0 wants to merge 8 commits into from

Conversation

@jakubgalecki0
Copy link
Contributor

@jakubgalecki0 jakubgalecki0 commented Jan 5, 2026 •
edited
Loading

Proposed commit message

Add new data_stream for health metrics on Always On Availability Groups.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 5, 2026

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the Integration:microsoft_sqlserver Microsoft SQL Server label Jan 8, 2026
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jan 9, 2026
muthu-mps
muthu-mps reviewed Jan 12, 2026
View reviewed changes
packages/microsoft_sqlserver/data_stream/availability_groups/fields/fields.yml Outdated
- name: primary_recovery_health
type: long
metric_type: gauge
description: Primary replica recovery health (0 = ONLINE_IN_PROGRESS, 1 = ONLINE. NULL if not primary).
Copy link
Contributor

@muthu-mps muthu-mps Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is this field going to get NULL value? Should the field data type changed to accept NULL value?
  • same applies for seconday_recovery_health field.

Copy link
Contributor Author

@jakubgalecki0 jakubgalecki0 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah values can be NULL depending on replica we are connected to (primary/secondary). Adjusted data type to keyword.

@jakubgalecki0 jakubgalecki0 marked this pull request as ready for review January 14, 2026 11:02
@jakubgalecki0 jakubgalecki0 requested a review from a team as a code owner January 14, 2026 11:02
@elasticmachine
Copy link

elasticmachine commented Jan 14, 2026

💚 Build Succeeded

History

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Jan 14, 2026
@muthu-mps muthu-mps requested a review from alaudazzi January 16, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muthu-mps muthu-mps muthu-mps left review comments

@alaudazzi alaudazzi Awaiting requested review from alaudazzi

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Microsoft SQL Server] Add AlwaysOnAvailability Metricset

4 participants

@jakubgalecki0 @elasticmachine @muthu-mps @andrewkroh